Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/history/history_types_unittest.cc

Issue 7618028: Tweak typed-count Usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autocomplete/history_url_provider_unittest.cc ('K') | « chrome/browser/history/history_types.cc ('k') | chrome/browser/history/in_memory_url_index_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_types_unittest.cc
===================================================================
--- chrome/browser/history/history_types_unittest.cc (revision 97032)
+++ chrome/browser/history/history_types_unittest.cc (working copy)
@@ -174,13 +174,13 @@
url_row.set_title(UTF8ToUTF16("Google"));
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, threshold));
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, base::Time()));
- url_row.set_visit_count(kLowQualityMatchVisitLimit + 1);
+ url_row.set_visit_count(kLowQualityMatchVisitLimit);
EXPECT_TRUE(RowQualifiesAsSignificant(url_row, threshold));
EXPECT_TRUE(RowQualifiesAsSignificant(url_row, base::Time()));
url_row.set_visit_count(1);
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, threshold));
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, base::Time()));
- url_row.set_typed_count(kLowQualityMatchTypedLimit + 1);
+ url_row.set_typed_count(kLowQualityMatchTypedLimit);
EXPECT_TRUE(RowQualifiesAsSignificant(url_row, threshold));
EXPECT_TRUE(RowQualifiesAsSignificant(url_row, base::Time()));
url_row.set_typed_count(0);
« chrome/browser/autocomplete/history_url_provider_unittest.cc ('K') | « chrome/browser/history/history_types.cc ('k') | chrome/browser/history/in_memory_url_index_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698