Issue 7618021: base: Fix the TODO in ListValue::Remove().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618021: base: Fix the TODO in ListValue::Remove(). (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

base: Fix the TODO in ListValue::Remove(). Change the return type of Remove() to bool, and add a size_t output parameter. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96702

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -23 lines)			Patch
M	base/values.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/values.cc	View		1 chunk	+6 lines, -8 lines	0 comments	Download
M	base/values_unittest.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_notification_provider.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/external_policy_extension_loader_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/translate/translate_prefs.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM