Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4299)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 7618016: Additional fixes for prerender/instant + browsing history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wrong signature Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index cb83264f840e68963048438db455114720bd6db3..f1590e710d96b03ff6e2a8bf3e67a36bba23242a 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -501,6 +501,14 @@ bool PrerenderManager::MaybeUsePrerenderedPage(TabContents* tab_contents,
return false;
}
+ // If the prerendered page is in the middle of a cross-site navigation,
+ // don't swap it in because there isn't a good way to merge histories.
+ if (prerender_contents->IsCrossSiteNavigationPending()) {
+ prerender_contents.release()->Destroy(
+ FINAL_STATUS_CROSS_SITE_NAVIGATION_PENDING);
+ return false;
+ }
+
int child_id, route_id;
CHECK(prerender_contents->GetChildId(&child_id));
CHECK(prerender_contents->GetRouteId(&route_id));

Powered by Google App Engine
This is Rietveld 408576698