Additional fixes for prerender/instant + browsing history.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 578 matching lines @@
   FOR_EACH_OBSERVER(TabContentsObserver,
                     observers_,
                     NavigateToPendingEntry(entry.url(), reload_type));
 
   if (delegate_)
     delegate_->DidNavigateToPendingEntry(this);
 
   return true;
 }
 
-void TabContents::SetHistoryLengthAndClear(int history_length) {
+void TabContents::SetHistoryLengthAndClear(const SiteInstance* site_instance,
+                                           int history_length,
+                                           int32 page_id) {
   RenderViewHost* rvh = render_view_host();
   if (!rvh)
     return;
+  // It's possible that the current render view host is different from the
+  // one that needs to be pruned.

[Charlie Reis, 2011/08/11 20:49:24]

Well, we're hoping it isn't possible if called correctly, but we want to be
safe.  Let's rephrase to something like "Ensure that we update the history of
the intended RenderView."

+  if (rvh->site_instance() != site_instance) {
+    LOG(ERROR) << "Mismatches site instance";
+    return;
+  }
   rvh->Send(new ViewMsg_SetHistoryLengthAndClear(rvh->routing_id(),
-                                                 history_length));
+                                                 history_length,
+                                                 page_id));
 }
 
 void TabContents::Stop() {
   render_manager_.Stop();
   FOR_EACH_OBSERVER(TabContentsObserver, observers_, StopNavigation());
 }
 
 TabContents* TabContents::Clone() {
   // We create a new SiteInstance so that the new tab won't share processes
   // with the old one. This can be changed in the future if we need it to share
@@ skipping 1305 matching lines @@
 }
 
 void TabContents::SwapInRenderViewHost(RenderViewHost* rvh) {
   render_manager_.SwapInRenderViewHost(rvh);
 }
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }