Issue 7618014: Revert 96406 - Print preview page selection should not require a rerendering of draft pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618014: Revert 96406 - Print preview page selection should not require a rerendering of draft pages. (Closed)

Created:
9 years, 4 months ago by kmadhusu

Modified:
9 years, 4 months ago

Reviewers:
kmadhusu

CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 96406 - Print preview page selection should not require a rerendering of draft pages. On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them. 1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|. 2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview| BUG=84383 TEST=print preview works after code changes. Review URL: http://codereview.chromium.org/7544018 TBR=kmadhusu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -410 lines)			Patch
M	chrome/browser/printing/print_preview_message_handler.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	5 chunks	+15 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/print_preview/page_settings.js	View	4 chunks	+5 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	8 chunks	+12 lines, -65 lines	0 comments	Download
M	chrome/common/print_messages.h	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/renderer/mock_printer.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/mock_printer.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/mock_render_thread.cc	View	3 chunks	+3 lines, -26 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	7 chunks	+17 lines, -27 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	15 chunks	+55 lines, -88 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_browsertest.cc	View	4 chunks	+7 lines, -70 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	2 chunks	+7 lines, -17 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View	3 chunks	+34 lines, -53 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	2 chunks	+9 lines, -22 lines	0 comments	Download
M	printing/print_job_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/print_job_constants.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages