Issue 7618012: Change AddElementsToFixedArray to work on FixedArrayBase rather than JSObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7618012: Change AddElementsToFixedArray to work on FixedArrayBase rather than JSObject (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Change AddElementsToFixedArray to work on FixedArrayBase rather than JSObject In the process, make ElementsAccessors work internally more seamlessly with FixedArrayBase. R=svenpanne@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8930

Patch Set 1 #

Patch Set 2 : fix whitespce #

Total comments: 1

Patch Set 3 : review feedback #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -47 lines)			Patch
M	src/elements.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/elements.cc	View	1 2	8 chunks	+36 lines, -44 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

9 years, 4 months ago (2011-08-12 08:20:43 UTC) #2

LGTM when the ASSERT is removed.

http://codereview.chromium.org/7618012/diff/3001/src/elements.cc
File src/elements.cc (right):

http://codereview.chromium.org/7618012/diff/3001/src/elements.cc#newcode142
src/elements.cc:142: ASSERT(value->IsString() || value->IsNumber());
This ASSERT should be removed to make this method more general.

Expand Messages | Collapse Messages