Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 7618010: Merge 92269 - [Chromium] Fix OOP font loading to work on 10.6.6 and above. (Closed)

Created:
9 years, 4 months ago by jeremy
Modified:
9 years, 4 months ago
Reviewers:
jeremy
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92269 - [Chromium] Fix OOP font loading to work on 10.6.6 and above. https://bugs.webkit.org/show_bug.cgi?id=65543 In 10.6.6 the function used to get the unique ID for an NSFont in the renderer was changed so it fails in the sandbox (it now tries to access the on-disk font file). In order to work around this, we get the font ID from the browser process. To speed things up, we introduce 2 levels of caching in WebKit. A font name cache where we can perform a quick lookup without the need for the font id and a font id cache which we can only lookup in after getting the unique ID from the browser process. Reviewed by Kenneth Russell. No new tests since this is not readily testable. Source/WebCore: * platform/chromium/PlatformBridge.h: * platform/graphics/chromium/CrossProcessFontLoading.h: * platform/graphics/chromium/CrossProcessFontLoading.mm: (WebCore::MemoryActivatedFont::create): (WebCore::MemoryActivatedFont::MemoryActivatedFont): (WebCore::MemoryActivatedFont::~MemoryActivatedFont): Source/WebKit/chromium: * public/mac/WebSandboxSupport.h: Plumb font ID parameter through. * src/PlatformBridge.cpp: (WebCore::PlatformBridge::loadFont): ditto. TBR=jeremy@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -34 lines) Patch
M Source/WebCore/platform/chromium/PlatformBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm View 6 chunks +80 lines, -25 lines 0 comments Download
M Source/WebKit/chromium/public/mac/WebSandboxSupport.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/PlatformBridge.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jeremy
9 years, 4 months ago (2011-08-11 12:44:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698