Simplify handling of exits from with and catch.

Simplify handling of exits from with and catch.

Remove the try/finally used for with and catch.  Instead of using
try/finally to handle break and continue from with or catch,
statically track nesting dept and clean up when compiling break or
continue.

And instead of using try/finally to handle throw to handler in a frame
whose pc is inside a with or catch, store the context that the handler
should run in in the handler itself.

BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=8922

[Kevin Millikin (Chromium), 2011-08-11 10:37:18]

I have separate change of cleanup after this one (e.g., we can remove the exit
context statements).

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc#newcode94
src/full-codegen.cc:94: Visit(stmt->expression());
I'm not sure this is right, I'll check with Soeren.

[Vyacheslav Egorov (Chromium), 2011-08-11 11:21:55]

seems almost ok, but I'll need another pass after you fix the bug.

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc#newcode940
src/full-codegen.cc:940: }
Break should also patch context in the stack slot:

-------------------
var o = { x: function () { }, y: function () { print("bazinga!"); } };

function foo() {
  while (true) {
    with (o) {
      x();
      break;
    }
  }
  baz(); // esi fill be restored from stack after the call
  with ({}) y(); // bazinga
}

function baz() {}

foo();
-------------------

(add this test to mjsunit).

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.h#newcode150
src/full-codegen.h:150: // contains the value in case of a return).
Comment is out of date. Please update.

[Kevin Millikin (Chromium), 2011-08-11 11:30:50]

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.cc#newcode940
src/full-codegen.cc:940: }
Oops, yes.  Good catch.

[Kevin Millikin (Chromium), 2011-08-11 15:22:20]

Please take another look.

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/7618007/diff/1/src/full-codegen.h#newcode150
src/full-codegen.h:150: // contains the value in case of a return).
On 2011/08/11 11:21:55, Vyacheslav Egorov wrote:
> Comment is out of date. Please update.

Done.

[Vyacheslav Egorov (Chromium), 2011-08-12 10:04:52]

LGTM

http://codereview.chromium.org/7618007/diff/4002/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/7618007/diff/4002/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:1180: // (r3 == IN_JS_ENTRY) == (fp == 0) == (cp
== 0), so we could test
r3 == ENTRY to be aligned with code?

[Kevin Millikin (Chromium), 2011-08-12 11:33:45]

http://codereview.chromium.org/7618007/diff/4002/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/7618007/diff/4002/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:1180: // (r3 == IN_JS_ENTRY) == (fp == 0) == (cp
== 0), so we could test
On 2011/08/12 10:04:52, Vyacheslav Egorov wrote:
> r3 == ENTRY to be aligned with code?

Yes, thanks.