Add scroll and gesture message filters for UIPI Flash.

Add scroll and gesture message filters for UIPI Flash. 

Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL, WM_APPCOMMAND (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.

One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported). 

BUG=86810
TEST=None.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96876

[jschuh, 2011-08-11 20:00:59]

@brettw - Content review.
@ananta - Plugin changes.
@cpu - In case you have anything to add.

[brettw, 2011-08-11 20:53:26]

LGTM. I don't really understand this, hopefully Ananta gives a good review.

[jschuh, 2011-08-11 22:00:06]

@jam - Turns out @ananta is out. Do you mind reviewing this?

[Bernhard Bauer, 2011-08-12 12:16:33]

webkit/plugins/npapi/ LGTM.

[jschuh, 2011-08-12 13:27:40]

@cpu - Since @ananta is out and you're the next most familiar with the actual
meat of the change, do you mind doing a quick review pass?

[cpu_(ooo_6.6-7.5), 2011-08-12 18:13:04]

lgtm

http://codereview.chromium.org/7617019/diff/7002/chrome/browser/renderer_host...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7617019/diff/7002/chrome/browser/renderer_host...
chrome/browser/renderer_host/render_widget_host_view_win.cc:459: typedef BOOL
(WINAPI *ChangeWindowMessageFilterExFunction)(
no need to GetProcAddress I think.

[jschuh, 2011-08-12 19:00:47]

http://codereview.chromium.org/7617019/diff/7002/chrome/browser/renderer_host...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7617019/diff/7002/chrome/browser/renderer_host...
chrome/browser/renderer_host/render_widget_host_view_win.cc:459: typedef BOOL
(WINAPI *ChangeWindowMessageFilterExFunction)(
On 2011/08/12 18:13:05, cpu wrote:
> no need to GetProcAddress I think.

Just tested on WinXP and we crash on a failed import. So, we aren't delay
loading and do need the GetProcAddress.

[M-A Ruel, 2011-08-12 23:50:05]

http://codereview.chromium.org/7617019/diff/12010/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7617019/diff/12010/chrome/browser/renderer_hos...
chrome/browser/renderer_host/render_widget_host_view_win.cc:466: static
ChangeWindowMessageFilterExFunction s_ChangeWindowMessageFilterEx =
Say No! to local static variables! In incurs a global variable look up at each
first access in the function everytime the function is called.

Actually, why are you making it static if it is to set its value at each
function call?

http://codereview.chromium.org/7617019/diff/12010/chrome/common/chrome_conten...
File chrome/common/chrome_content_client.cc (right):

http://codereview.chromium.org/7617019/diff/12010/chrome/common/chrome_conten...
chrome/common/chrome_content_client.cc:366: if (base::win::GetVersion() ==
base::win::VERSION_VISTA) {
And what about Windows 7 and later? If it's vista specific, I think you should
mention it in the comment.

http://codereview.chromium.org/7617019/diff/12010/chrome/common/chrome_conten...
chrome/common/chrome_content_client.cc:370: static
ChangeWindowMessageFilterFunction s_ChangeWindowMessageFilter =
Same

[jam, 2011-08-26 00:29:11]

drive-by since I just noticed this code

http://codereview.chromium.org/7617019/diff/24008/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/7617019/diff/24008/chrome/browser/renderer_hos...
chrome/browser/renderer_host/render_widget_host_view_win.cc:487:
::SetPropW(orig_parent, webkit::npapi::kNativeWindowClassFilterProp, NULL);
this needs a matching call to RemoveProp(). per the SetProp msdn documentation:


Before a window is destroyed (that is, before it returns from processing the
WM_NCDESTROY message), an application must remove all entries it has added to
the property list. The application must use the RemoveProp function to remove
the entries.