Issue 7617016: base: Add missing OVERRIDE annotations to overridden methods from Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7617016: base: Add missing OVERRIDE annotations to overridden methods from Value. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Add missing OVERRIDE annotations to overridden methods from Value. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96452

Patch Set 2 : fix comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
	M	base/values.h	View	1	6 chunks	+25 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/7617016/diff/1/base/values.h File base/values.h (right): http://codereview.chromium.org/7617016/diff/1/base/values.h#newcode137 base/values.h:137: // Value: Might be worth saying "overrides" or ...

9 years, 4 months ago (2011-08-11 20:29:28 UTC) #2

tfarina

9 years, 4 months ago (2011-08-11 20:56:05 UTC) #3

http://codereview.chromium.org/7617016/diff/1/base/values.h
File base/values.h (right):

http://codereview.chromium.org/7617016/diff/1/base/values.h#newcode137
base/values.h:137: // Value:
On 2011/08/11 20:29:28, Evan Martin wrote:
> Might be worth saying "overrides" or "implementation" on these comments. 
> ("Value:" doesn't mean a whole lot, you might as well delete the comment if
> that's all it's gonna say.)

Changed to // Overridden from Value:

Expand Messages | Collapse Messages

Issue 7617016: base: Add missing OVERRIDE annotations to overridden methods from Value. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix comments #

Messages