Issue 7617010: Change JSObject elements to be of type FixedArrayBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7617010: Change JSObject elements to be of type FixedArrayBase (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Kevin Millikin (Chromium), Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Change JSObject elements to be of type FixedArrayBase R=kmillikin@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8927

Patch Set 1 #

Total comments: 1

Patch Set 2 : review feedback #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	src/objects.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

9 years, 4 months ago (2011-08-12 11:11:22 UTC) #3

LGTM with a tiny stylistic issue only.

http://codereview.chromium.org/7617010/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/7617010/diff/1/src/objects-inl.h#newcode1341
src/objects-inl.h:1341: return reinterpret_cast<FixedArrayBase*>(array);
static_cast might be nicer here.

Expand Messages | Collapse Messages