Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5008)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc

Issue 7617006: views/bookmarks: Fix memory leak in BookmarkEditorView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more try Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
index 8ec3a59181f01b82d44471fa31143d316de24a93..cf481ff38b5149849598392ea35694b558d15850 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
@@ -69,7 +69,8 @@ class BookmarkEditorViewTest : public TestingBrowserProcessTest {
}
void SetURLText(const std::wstring& text) {
- editor_->url_tf_.SetText(text);
+ if (editor_->details_.type != BookmarkEditor::EditDetails::NEW_FOLDER)
+ editor_->url_tf_->SetText(text);
}
void ApplyEdits(BookmarkEditorView::EditorNode* node) {
@@ -82,7 +83,9 @@ class BookmarkEditorViewTest : public TestingBrowserProcessTest {
}
bool URLTFHasParent() {
- return editor_->url_tf_.parent();
+ if (editor_->details_.type == BookmarkEditor::EditDetails::NEW_FOLDER)
+ return false;
+ return editor_->url_tf_->parent();
}
MessageLoopForUI message_loop_;
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698