Issue 7616013: Dropping removed source file from the gyp build description.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7616013: Dropping removed source file from the gyp build description. (Closed)

Created:
9 years, 4 months ago by bradn

Modified:
8 years, 10 months ago

Reviewers:
iposva, Mads Ager (chromium), Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adding new marker for targets that rely on static library dependencies traversing none type targets. In preparation for a gyp change to the default behavior. BUG=None TEST=None R=ager@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10579

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gyp/v8.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iposva

Committed as r8912. -Ivan On 2011/08/11 17:55:05, iposva wrote: > LGTM > > Many thanks ...

9 years, 4 months ago (2011-08-11 22:41:44 UTC) #3

Jakob Kummerow

8 years, 10 months ago (2012-02-01 15:28:03 UTC) #5

The change in patch set 2 LGTM; I'll land it.

If you create a new codereview issue for each new, unrelated change, that'll
help avoid it flying under our radar for so long ;-)

Expand Messages | Collapse Messages