src/ia32/full-codegen-ia32.cc - Issue 7616009: Parse harmony let declarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 7616009: Parse harmony let declarations. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Updated tests. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 0056acc953ea477dbab1cf6f09062afcf6873682..bb75b1e6acb22922dd13505981523e1be1e4521d 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -737,8 +737,10 @@ void FullCodeGenerator::EmitDeclaration(Variable* variable,

__ push(esi);

__ push(Immediate(variable->name()));

// Declaration nodes are always introduced in one of two modes.

- ASSERT(mode == Variable::VAR || mode == Variable::CONST);

- PropertyAttributes attr = (mode == Variable::VAR) ? NONE : READ_ONLY;

+ ASSERT(mode == Variable::VAR ||

+ mode == Variable::CONST ||

+ mode == Variable::LET);

+ PropertyAttributes attr = (mode == Variable::CONST) ? READ_ONLY : NONE;

__ push(Immediate(Smi::FromInt(attr)));

// Push initial value, if any.

// Note: For variables we must not push an initial value (such as