Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: src/objects.cc

Issue 7615: Fix issue 116 by returning the value from SetFastElement. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-116.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
===================================================================
--- src/objects.cc (revision 513)
+++ src/objects.cc (working copy)
@@ -4655,7 +4655,7 @@
JSArray::cast(this)->set_length(Smi::FromInt(index + 1));
}
}
- return this;
+ return value;
}
// Allow gap in fast case.
@@ -4670,7 +4670,7 @@
SetFastElements(FixedArray::cast(obj));
if (IsJSArray()) JSArray::cast(this)->set_length(Smi::FromInt(index + 1));
FixedArray::cast(elements())->set(index, value);
- return this;
+ return value;
}
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-116.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698