Issue 7614001: [Sync] Add comment for SyncBackendHost::OnBackendInitialized

Issue 7614001: [Sync] Add comment for SyncBackendHost::OnBackendInitialized (Closed)

Created:
9 years, 4 months ago by akalin

Modified:
9 years, 4 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Add comment for SyncBackendHost::OnBackendInitialized BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96587

Patch Set 2 : Address comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	chrome/browser/sync/engine/syncapi.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/sync/glue/sync_backend_host.h	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM with nits http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/engine/syncapi.h File chrome/browser/sync/engine/syncapi.h (right): http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/engine/syncapi.h#newcode849 chrome/browser/sync/engine/syncapi.h:849: // |the following events: Is this ...

9 years, 4 months ago (2011-08-11 21:43:19 UTC) #2

akalin

9 years, 4 months ago (2011-08-12 18:24:26 UTC) #3

Address comments, committing

http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/engine/sync...
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/engine/sync...
chrome/browser/sync/engine/syncapi.h:849: // |the following events:
On 2011/08/11 21:43:19, timsteele wrote:
> Is this really the best spot for the full JsBackend doc?

I can't think of a better place that won't get outdated :( Suggestions?

http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/glue/sync_b...
File chrome/browser/sync/glue/sync_backend_host.h (right):

http://codereview.chromium.org/7614001/diff/1/chrome/browser/sync/glue/sync_b...
chrome/browser/sync/glue/sync_backend_host.h:66: // from the 'Backend' in
'OnBackendInitialized' (unfortunately).
On 2011/08/11 21:43:19, timsteele wrote:
> is |js_backend| only provided on |success| = true?

It's initialized only on success = true.  Added comment.

Expand Messages | Collapse Messages