Add preliminary Autofill support for 'autocompletetype' sections.

Add preliminary Autofill support for 'autocompletetype' sections.

BUG=92121
TEST=unit_tests --gtest_filter=AutofillManagerTest.FillFormWithAuthorSpecifiedSections:FormStructureTest.HeuristicsAutocompletetypeWithSections

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96506

[dhollowa, 2011-08-11 01:39:46]

http://codereview.chromium.org/7613015/diff/2001/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/7613015/diff/2001/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_manager.cc:106: bool SectionIsAutofilled(const
FormStructure* form_structure,
This kinda hurts my brains.  Seems like intermingling the logic for explicit
sections and implicit sections is the wrong approach.  |SectionIsAutofilled| for
explicit sections is quite trivial I'd imagine, and a separate method for the
implicit at least wouldn't be more complicated than it was.

Also, I wonder if we'd gain, in the implicit case, by doing a pass to
|set_section| on each of the fields with synthetic labels.  And then we'd only
need the trivial version of |SectionIsAutofilled|.

That might answer your TODO question below.

[Ilya Sherman, 2011-08-11 03:33:43]

http://codereview.chromium.org/7613015/diff/2001/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/7613015/diff/2001/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_manager.cc:106: bool SectionIsAutofilled(const
FormStructure* form_structure,
On 2011/08/11 01:39:46, dhollowa wrote:
> This kinda hurts my brains.  Seems like intermingling the logic for explicit
> sections and implicit sections is the wrong approach.  |SectionIsAutofilled|
for
> explicit sections is quite trivial I'd imagine, and a separate method for the
> implicit at least wouldn't be more complicated than it was.
> 
> Also, I wonder if we'd gain, in the implicit case, by doing a pass to
> |set_section| on each of the fields with synthetic labels.  And then we'd only
> need the trivial version of |SectionIsAutofilled|.
> 
> That might answer your TODO question below.

Done.

[dhollowa, 2011-08-11 14:52:14]

LGTM /w nits.

http://codereview.chromium.org/7613015/diff/5001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure_unittest.cc (right):

http://codereview.chromium.org/7613015/diff/5001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure_unittest.cc:443:
ASCIIToUTF16("section-shipping given-name");
nit: indent (and below).

[Ilya Sherman, 2011-08-12 01:30:50]

http://codereview.chromium.org/7613015/diff/5001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure_unittest.cc (right):

http://codereview.chromium.org/7613015/diff/5001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure_unittest.cc:443:
ASCIIToUTF16("section-shipping given-name");
On 2011/08/11 14:52:14, dhollowa wrote:
> nit: indent (and below).

Done.  Thanks for the catch =)