Issue 7612017: Integrates SET_ONLINE and APPCACHE_STATUS atoms. Other commands for BrowserConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7612017: Integrates SET_ONLINE and APPCACHE_STATUS atoms. Other commands for BrowserConnection (Closed)

Created:
9 years, 4 months ago by alnayeem

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, kkania, berrada

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

In chromedriver, integrate SET_ONLINE and APPCACHE_STATUS atoms. Other commands for BrowserConnection and ApplicationCache are not implemented. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96488

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2809 lines, -1310 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/test/webdriver/commands/appcache_status_command.h	View	1 chunk	+38 lines, -0 lines	1 comment	Download
A	chrome/test/webdriver/commands/appcache_status_command.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/test/webdriver/commands/browser_connection_commands.h	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome/test/webdriver/commands/browser_connection_commands.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/server.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/session.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/session.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	third_party/webdriver/README.chromium	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	third_party/webdriver/atoms.h	View	11 chunks	+2604 lines, -1309 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kkania

LGTM http://codereview.chromium.org/7612017/diff/1/chrome/test/webdriver/commands/appcache_status_command.h File chrome/test/webdriver/commands/appcache_status_command.h (right): http://codereview.chromium.org/7612017/diff/1/chrome/test/webdriver/commands/appcache_status_command.h#newcode29 chrome/test/webdriver/commands/appcache_status_command.h:29: // A call with HTTP GET will return ...

9 years, 4 months ago (2011-08-11 21:46:15 UTC) #2

Change committed as 96488

Expand Messages | Collapse Messages