chrome/browser/chrome_content_browser_client.cc - Issue 7612016: Tie extension/app initialization to RenderView creation, not RenderViewHost creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 7612016: Tie extension/app initialization to RenderView creation, not RenderViewHost creation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switch to initializing extensions when a RenderView is created, as opposed to a RenderViewHost. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/extensions/app_process_apitest.cc » ('j') | content/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index d811568fd75ec341187cc5f13ce896f05f9a26e0..df6f811ce919f96ccd61b13868788c5aff4fe5a6 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -81,7 +81,7 @@

namespace {

-void InitRenderViewHostForExtensions(RenderViewHost* render_view_host) {

+void InitRenderViewForExtensions(RenderViewHost* render_view_host) {

// Note that due to GetEffectiveURL(), even hosted apps will have a

// chrome-extension:// URL for their site, so we can ignore that wrinkle here.

SiteInstance* site_instance = render_view_host->site_instance();

@@ -170,8 +170,11 @@ void ChromeContentBrowserClient::RenderViewHostCreated(

new ChromeRenderViewHostObserver(render_view_host);

new DevToolsHandler(render_view_host);

new ExtensionMessageHandler(render_view_host);

- InitRenderViewHostForExtensions(render_view_host);

+void ChromeContentBrowserClient::RenderViewCreated(

+ RenderViewHost* render_view_host) {

+ InitRenderViewForExtensions(render_view_host);

}

void ChromeContentBrowserClient::BrowserRenderProcessHostCreated(