Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: content/browser/renderer_host/render_view_host.cc

Issue 7612016: Tie extension/app initialization to RenderView creation, not RenderViewHost creation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch to initializing extensions when a RenderView is created, as opposed to a RenderViewHost. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host.h" 5 #include "content/browser/renderer_host/render_view_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 params.view_id = routing_id(); 185 params.view_id = routing_id();
186 params.session_storage_namespace_id = session_storage_namespace_->id(); 186 params.session_storage_namespace_id = session_storage_namespace_->id();
187 params.frame_name = frame_name; 187 params.frame_name = frame_name;
188 Send(new ViewMsg_New(params)); 188 Send(new ViewMsg_New(params));
189 189
190 // If it's enabled, tell the renderer to set up the Javascript bindings for 190 // If it's enabled, tell the renderer to set up the Javascript bindings for
191 // sending messages back to the browser. 191 // sending messages back to the browser.
192 Send(new ViewMsg_AllowBindings(routing_id(), enabled_bindings_)); 192 Send(new ViewMsg_AllowBindings(routing_id(), enabled_bindings_));
193 // Let our delegate know that we created a RenderView. 193 // Let our delegate know that we created a RenderView.
194 delegate_->RenderViewCreated(this); 194 delegate_->RenderViewCreated(this);
195 content::GetContentClient()->browser()->RenderViewCreated(this);
jam 2011/08/11 18:13:37 It's best to avoid adding methods to ContentBrowse
195 196
196 FOR_EACH_OBSERVER( 197 FOR_EACH_OBSERVER(
197 RenderViewHostObserver, observers_, RenderViewHostInitialized()); 198 RenderViewHostObserver, observers_, RenderViewHostInitialized());
198 199
199 return true; 200 return true;
200 } 201 }
201 202
202 bool RenderViewHost::IsRenderViewLive() const { 203 bool RenderViewHost::IsRenderViewLive() const {
203 return process()->HasConnection() && renderer_initialized_; 204 return process()->HasConnection() && renderer_initialized_;
204 } 205 }
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1334 if (view) { 1335 if (view) {
1335 view->ShowPopupMenu(params.bounds, 1336 view->ShowPopupMenu(params.bounds,
1336 params.item_height, 1337 params.item_height,
1337 params.item_font_size, 1338 params.item_font_size,
1338 params.selected_item, 1339 params.selected_item,
1339 params.popup_items, 1340 params.popup_items,
1340 params.right_aligned); 1341 params.right_aligned);
1341 } 1342 }
1342 } 1343 }
1343 #endif 1344 #endif
OLDNEW
« content/browser/content_browser_client.h ('K') | « content/browser/mock_content_browser_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698