Issue 7612015: sync: Make BaseNode::GetTitle() return std::string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7612015: sync: Make BaseNode::GetTitle() return std::string. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

sync: Make BaseNode::GetTitle() return std::string. Note: This was a TODO for akalin. BUG=None TEST=None R=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96382

Patch Set 3 : unittests fixes #

Patch Set 5 : fix profile sync unittest #

Patch Set 6 : fix syncapi_unittest #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -31 lines)			Patch
M	chrome/browser/sync/engine/syncapi.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	1	4 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi_unittest.cc	View	1 2 3 4 5	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View	1 2 3 4	5 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

akalin

LGTM http://codereview.chromium.org/7612015/diff/1/chrome/browser/sync/engine/syncapi.cc File chrome/browser/sync/engine/syncapi.cc (right): http://codereview.chromium.org/7612015/diff/1/chrome/browser/sync/engine/syncapi.cc#newcode189 chrome/browser/sync/engine/syncapi.cc:189: if (out) better to CHECK(out)

9 years, 4 months ago (2011-08-11 00:23:01 UTC) #1

tfarina

9 years, 4 months ago (2011-08-11 00:25:41 UTC) #2

http://codereview.chromium.org/7612015/diff/1/chrome/browser/sync/engine/sync...
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/7612015/diff/1/chrome/browser/sync/engine/sync...
chrome/browser/sync/engine/syncapi.cc:189: if (out)
On 2011/08/11 00:23:02, akalin wrote:
> better to CHECK(out)

Done.