[ntp4] Bookmarks page implementation, first-pass.

chrome/browser/resources/ntp4/new_tab.js

Index: chrome/browser/resources/ntp4/new_tab.js
===================================================================
--- chrome/browser/resources/ntp4/new_tab.js	(revision 96479)
+++ chrome/browser/resources/ntp4/new_tab.js	(working copy)
@@ -189,7 +189,8 @@
 
     bookmarksPage = new ntp4.BookmarksPage();
     appendTilePage(bookmarksPage, localStrings.getString('bookmarksPage'));
-    chrome.send('getBookmarks');
+    // TODO(csilv): persist last folder
+    chrome.send('getBookmarksData', ['0']);

[Evan Stade, 2011/08/12 21:13:30]

you should make it pass no arguments for the root folder instead of assuming
knowledge of the root id being 0.

Also, you can pass numbers rather than strings as parameters (on the other side
you have to GetDouble and cast to int)

[arv (Not doing code reviews), 2011/08/13 01:02:07]

Bookmark IDs are int64 so this needs to be done as strings.

[csilv, 2011/08/13 01:09:21]

Done.

   }
 
   /**
@@ -670,6 +671,10 @@
     mostVisitedPage.data = data;
   }
 
+  function setBookmarksData(data) {
+    bookmarksPage.data = data;
+  }
+
   /**
    * Check the directionality of the page.
    * @return {boolean} True if Chrome is running an RTL UI.
@@ -706,6 +711,7 @@
     themeChanged: themeChanged,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
     setMostVisitedPages: setMostVisitedPages,
+    setBookmarksData: setBookmarksData,

[Evan Stade, 2011/08/12 21:13:30]

can you alphabetize this list

[csilv, 2011/08/13 01:09:21]

Done.

     showNotification: showNotification,
     saveAppPageName: saveAppPageName
   };