[ntp4] Bookmarks page implementation, first-pass.

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 171 matching lines @@
 
     cr.ui.decorate($('recently-closed-menu-button'), ntp4.RecentMenuButton);
     chrome.send('getRecentlyClosedTabs');
 
     mostVisitedPage = new ntp4.MostVisitedPage();
     appendTilePage(mostVisitedPage, localStrings.getString('mostvisited'));
     chrome.send('getMostVisited');
 
     bookmarksPage = new ntp4.BookmarksPage();
     appendTilePage(bookmarksPage, localStrings.getString('bookmarksPage'));
-    chrome.send('getBookmarks');
+    // TODO(csilv): persist last folder
+    chrome.send('getBookmarksData', ['0']);

[Evan Stade, 2011/08/12 21:13:30]

you should make it pass no arguments for the root folder instead of assuming
knowledge of the root id being 0.

Also, you can pass numbers rather than strings as parameters (on the other side
you have to GetDouble and cast to int)

[arv (Not doing code reviews), 2011/08/13 01:02:07]

Bookmark IDs are int64 so this needs to be done as strings.

[csilv, 2011/08/13 01:09:21]

Done.

   }
 
   /**
    * Simple common assertion API
    * @param {*} condition The condition to test.  Note that this may be used to
    *     test whether a value is defined or not, and we don't want to force a
    *     cast to Boolean.
    * @param {string=} opt_message A message to use in any error.
    */
   function assert(condition, opt_message) {
@@ skipping 460 matching lines @@
   }
 
   function setRecentlyClosedTabs(dataItems) {
     $('recently-closed-menu-button').dataItems = dataItems;
   }
 
   function setMostVisitedPages(data, hasBlacklistedUrls) {
     mostVisitedPage.data = data;
   }
 
+  function setBookmarksData(data) {
+    bookmarksPage.data = data;
+  }
+
   /**
    * Check the directionality of the page.
    * @return {boolean} True if Chrome is running an RTL UI.
    */
   function isRTL() {
     return document.documentElement.dir == 'rtl';
   }
 
   /*
    * Save the name of an app page.
@@ skipping 16 matching lines @@
     enterRearrangeMode: enterRearrangeMode,
     getAppsCallback: getAppsCallback,
     getCardSlider: getCardSlider,
     getAppsPageIndex: getAppsPageIndex,
     initialize: initialize,
     isRTL: isRTL,
     leaveRearrangeMode: leaveRearrangeMode,
     themeChanged: themeChanged,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
     setMostVisitedPages: setMostVisitedPages,
+    setBookmarksData: setBookmarksData,

[Evan Stade, 2011/08/12 21:13:30]

can you alphabetize this list

[csilv, 2011/08/13 01:09:21]

Done.

     showNotification: showNotification,
     saveAppPageName: saveAppPageName
   };
 });
 
 // publish ntp globals
 // TODO(estade): update the content handlers to use ntp namespace instead of
 // making these global.
 var assert = ntp4.assert;
 var getAppsCallback = ntp4.getAppsCallback;
 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
 var themeChanged = ntp4.themeChanged;
 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
 var setMostVisitedPages = ntp4.setMostVisitedPages;
 
 document.addEventListener('DOMContentLoaded', ntp4.initialize);