Ignore and navigate to url when opening bookmark manager for a node.

Ignore and navigate to url when opening bookmark manager for a node.

This fixes the issue that bookmark manager allows you to open to a specific folder (using a location hash) but if it is already open it does not navigate to that folder.

BUG=None
TEST=Manually opened the bookmark manager to one folder, then to another and verified that it did navigate the singleton tab to the second folder.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96930

[Evan Stade, 2011-08-11 17:43:24]

http://codereview.chromium.org/7610012/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7610012/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:1251: params.path_behavior =
browser::NavigateParams::IGNORE_AND_NAVIGATE;
If we always want this, then why do we even have the enumeration? when is
IGNORE_AND_STAY_PUT ever used? when will RESPECT be used after this change?

[flackr, 2011-08-12 14:44:10]

http://codereview.chromium.org/7610012/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7610012/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:1251: params.path_behavior =
browser::NavigateParams::IGNORE_AND_NAVIGATE;
So after playing with the other sections (history, downloads, etc) I'm not sure
whether we always want this or not. I'm not sure if opening downloads should
take you to all downloads if you already have a downloads tab with a search
open. I'll just special case it for OpenBookmarkManagerForNode for now as is
done with ShowOptionsTab.

On 2011/08/11 17:43:24, Evan Stade wrote:
> If we always want this, then why do we even have the enumeration? when is
> IGNORE_AND_STAY_PUT ever used? when will RESPECT be used after this change?

[Evan Stade, 2011-08-12 21:50:06]

lgtm

[commit-bot: I haz the power, 2011-08-16 12:39:54]

Change committed as 96930