Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4435)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

Issue 7610011: Update Sad Tab help text and link. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor cleanup in SadTabController. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
index 16b54a1d58f8c86002e1c0c97e7b26efe49f2e94..bfb983f9edd35889c4c1370bf1ee539250d3d96a 100644
--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
@@ -13,12 +13,12 @@
@interface SadTabView (ExposedForTesting)
// Implementation is below.
-- (NSButton*)linkButton;
+- (NSTextView*)helpTextView;
@end
@implementation SadTabView (ExposedForTesting)
-- (NSButton*)linkButton {
- return linkButton_;
+- (NSTextView*)helpTextView {
+ return help_.get();
}
@end
@@ -62,9 +62,9 @@ class SadTabControllerTest : public RenderViewHostTestHarness {
return controller;
}
- NSButton* GetLinkButton(SadTabController* controller) {
+ NSTextView* GetHelpTextView(SadTabController* controller) {
SadTabView* view = static_cast<SadTabView*>([controller view]);
- return ([view linkButton]);
+ return ([view helpTextView]);
}
static bool link_clicked_;
@@ -77,24 +77,24 @@ bool SadTabControllerTest::link_clicked_;
TEST_F(SadTabControllerTest, WithTabContents) {
scoped_nsobject<SadTabController> controller(CreateController());
EXPECT_TRUE(controller);
- NSButton* link = GetLinkButton(controller);
- EXPECT_TRUE(link);
+ NSTextView* help = GetHelpTextView(controller);
+ EXPECT_TRUE(help);
}
TEST_F(SadTabControllerTest, WithoutTabContents) {
DeleteContents();
scoped_nsobject<SadTabController> controller(CreateController());
EXPECT_TRUE(controller);
- NSButton* link = GetLinkButton(controller);
- EXPECT_FALSE(link);
+ NSTextView* help = GetHelpTextView(controller);
+ EXPECT_FALSE(help);
}
TEST_F(SadTabControllerTest, ClickOnLink) {
scoped_nsobject<SadTabController> controller(CreateController());
- NSButton* link = GetLinkButton(controller);
- EXPECT_TRUE(link);
+ NSTextView* help = GetHelpTextView(controller);
+ EXPECT_TRUE(help);
EXPECT_FALSE(link_clicked_);
- [link performClick:link];
+ [help clickedOnLink:nil atIndex:0];
EXPECT_TRUE(link_clicked_);
}

Powered by Google App Engine
This is Rietveld 408576698