If no locale data files can be found, show a dialog and exit

If no locale data files can be found, show a dialog and exit
with RESULT_CODE_MISSING_DATA.  We used to just CHECK() crash.

BUG=69194
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96627

[eroman, 2011-08-11 02:17:17]

LGTM, thanks!

(however I have no power of approval).

http://codereview.chromium.org/7610009/diff/2001/chrome/browser/browser_main.h
File chrome/browser/browser_main.h (right):

http://codereview.chromium.org/7610009/diff/2001/chrome/browser/browser_main....
chrome/browser/browser_main.h:205: void ShowMissingLocaleMessageBox(const char*
message, const char* title);
nit: might want to specify that the expected encoding is ASCII.

Also the naming seems a little weird given that we pass in the message and
title. If you extracted them to constants, could make this a zero-arg func.

[tony, 2011-08-12 17:03:11]

Carlos, can you review to make sure that the usage of
chrome::RESULT_CODE_MISSING_DATA is OK?

http://codereview.chromium.org/7610009/diff/2001/chrome/browser/browser_main.h
File chrome/browser/browser_main.h (right):

http://codereview.chromium.org/7610009/diff/2001/chrome/browser/browser_main....
chrome/browser/browser_main.h:205: void ShowMissingLocaleMessageBox(const char*
message, const char* title);
On 2011/08/11 02:17:17, eroman wrote:
> Also the naming seems a little weird given that we pass in the message and
> title. If you extracted them to constants, could make this a zero-arg func.

I moved the strings to constants in browser_main.h.

[cpu_(ooo_6.6-7.5), 2011-08-12 18:17:50]

lgtm

[commit-bot: I haz the power, 2011-08-12 21:41:02]

Change committed as 96627