Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 7610008: Sync Promo: Show profile avatar next to user name (Closed)

Created:
9 years, 4 months ago by sail
Modified:
9 years, 4 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Sync Promo: Show profile avatar next to user name If the user is signed into sync then we now show the profile avatar next to their user name in the sync promo. We only show the profile avatar icon if the user has created multiple profiles (this matches the behavior of the avatar button in the browser window). This change also adds hooks to show the profile menu if the user clicks their user name. Currently this doesn't do anything. I'll change it to show the profile menu once the profile menu CL lands. BUG=91009 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96527

Patch Set 1 #

Patch Set 2 : Fix comments #

Patch Set 3 : Update strings #

Patch Set 4 : rebase #

Patch Set 5 : fix build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -34 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/new_tab.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/new_tab_sync_promo.css View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/new_tab_sync_promo.js View 1 2 3 chunks +66 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 2 3 4 4 chunks +57 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sail
9 years, 4 months ago (2011-08-10 21:43:15 UTC) #1
sail
I updated the login status message to say "Signed in to Chrome as pat@example.com" as ...
9 years, 4 months ago (2011-08-10 23:09:18 UTC) #2
James Hawkins
LGTM
9 years, 4 months ago (2011-08-11 21:13:36 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.h. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.h ...
9 years, 4 months ago (2011-08-11 22:21:41 UTC) #4
commit-bot: I haz the power
Try job failure for 7610008-9001 (retry) on linux for step "compile" (clobber build). It's a ...
9 years, 4 months ago (2011-08-12 05:18:46 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 07:49:56 UTC) #6
Change committed as 96527

Powered by Google App Engine
This is Rietveld 408576698