Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 7610006: Add crash_service64.exe to the list of files to archive on Buildbot (Closed)

Created:
9 years, 4 months ago by Mark Seaborn
Modified:
9 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add crash_service64.exe to the list of files to archive on Buildbot "FILES" is used when producing zip snapshots of Chromium. This file is read by chrome/trunk/tools/build/scripts/slave/chromium/archive_build.py. This will allow NaCl to invoke crash_service64.exe in the NaCl standalone build, although this is mainly for consistency across standalone and non-standalone test runs, since the NaCl standalone build won't support producing Breakpad crash dumps. Add to "FILES.cfg" for consistency. This file is read by chrome-internal/trunk/tools/build/scripts/slave-internal/stage_build.py. BUG=89730 TEST=untestable Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96290

Patch Set 1 #

Patch Set 2 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/tools/build/win/FILES View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
9 years, 4 months ago (2011-08-10 21:27:09 UTC) #1
bradn
LGTM
9 years, 4 months ago (2011-08-10 21:32:24 UTC) #2
commit-bot: I haz the power
Can't apply patch for file chrome/tools/build/win/FILES.cfg. While running patch -p1 --forward --force; patching file chrome/tools/build/win/FILES.cfg ...
9 years, 4 months ago (2011-08-10 21:33:03 UTC) #3
commit-bot: I haz the power
Change committed as 96290
9 years, 4 months ago (2011-08-11 01:16:43 UTC) #4
Roger McFarlane (Google)
9 years, 4 months ago (2011-08-11 15:36:40 UTC) #5
This change breaks the official buildbot!

http://chrome-master2.mtv.corp.google.com:8010/builders/chrome%20official/bui...

Perhaps this target does not get built in official mode?

Powered by Google App Engine
This is Rietveld 408576698