third_party/sfntly/src/subsetter/subsetter_impl.cc - Issue 7610005: Fortify against corrupted font.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/sfntly/src/subsetter/subsetter_impl.cc

Issue 7610005: Fortify against corrupted font. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Update to resolve DEPS conflict Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/sfntly/src/subsetter/subsetter_impl.cc

diff --git a/third_party/sfntly/src/subsetter/subsetter_impl.cc b/third_party/sfntly/src/subsetter/subsetter_impl.cc

index 4d4b0ff10e2ae67c0c2ccb1aa3d980bae76f669e..217bd12a44bcbd0a7cace6390d5f85822fedf4b1 100644

--- a/third_party/sfntly/src/subsetter/subsetter_impl.cc

+++ b/third_party/sfntly/src/subsetter/subsetter_impl.cc

@@ -154,6 +154,9 @@ bool SubsetterImpl::HasName(const char* font_name, Font* font) {

typedef std::map<int32_t, UnicodeString> NameMap;

NameMap names;

NameTablePtr name_table = down_cast<NameTable*>(font->GetTable(Tag::name));

+ if (name_table == NULL) {

+ return false;

+ }

for (int32_t i = 0; i < name_table->NameCount(); ++i) {

switch(name_table->NameId(i)) {

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »