More.

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
@@ skipping 37 matching lines @@
 
 BrowserWindowCocoa::BrowserWindowCocoa(Browser* browser,
                                        BrowserWindowController* controller,
                                        NSWindow* window)
   : browser_(browser),
     controller_(controller),
     confirm_close_factory_(browser) {
   // This pref applies to all windows, so all must watch for it.
   registrar_.Add(this,
                  chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
                  NotificationService::AllSources());

[Peter Kasting, 2011/08/10 21:03:21]

Don't you want to change this (and the observer code) similarly to browser.cc?

[Elliot Glaysher, 2011/08/10 21:19:23]

I'm doing this in a per-notification way instead of per-file. (See our tracking
spreadsheet
https://docs.google.com/a/google.com/spreadsheet/ccc?key=0Ar4V_eAZl8_SdDB2THV...
) 

   registrar_.Add(this, chrome::NOTIFICATION_SIDEBAR_CHANGED,
-                 NotificationService::AllSources());
+                 Source<SidebarManager>(SidebarManager::GetInstance()));

[Peter Kasting, 2011/08/10 21:03:21]

Shouldn't the sidebar state be synced between normal and incognito profiles?  Or
am I mistaken about what the sidebar is...

[Elliot Glaysher, 2011/08/10 21:19:23]

The SidebarManager is currently a Singleton. It maps a TabContents to a Sidebar
object. This is just a case where it's easy to remove the AllSources() call and
listen directly on the single object that we're interested in.

(I believe this is an extensions feature. This is an extension API, not the side
tab stuff.)

 }
 
 BrowserWindowCocoa::~BrowserWindowCocoa() {
 }
 
 void BrowserWindowCocoa::Show() {
   // The Browser associated with this browser window must become the active
   // browser at the time |Show()| is called. This is the natural behaviour under
   // Windows, but |-makeKeyAndOrderFront:| won't send |-windowDidBecomeMain:|
   // until we return to the runloop. Therefore any calls to
@@ skipping 558 matching lines @@
 
 NSWindow* BrowserWindowCocoa::window() const {
   return [controller_ window];
 }
 
 void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) {
   if (tab_contents == browser_->GetSelectedTabContents()) {
     [controller_ updateSidebarForContents:tab_contents];
   }
 }