Made web-app bidi-compatible.

Made web-app bidi-compatible.

BUG=None
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96245

[Jamie, 2011-08-10 18:24:31]

This CL adds bidi support to the web-app. It will need checking more carefully
by a native speaker once we have a RTL translation available, but for now PTAL
to see if this conforms to best practice.

http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.css
File remoting/webapp/me2mom/choice.css (right):

http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.c...
remoting/webapp/me2mom/choice.css:19: direction: __MSG_@@bidi_dir__;
I don't think we're supposed to use CSS to set text direction, but I don't think
Chrome extensions can use __MSG__ substitutions in the HTML. If you know of a
better way of doing this, let me know.

[garykac, 2011-08-10 19:31:54]

On 2011/08/10 18:24:31, Jamie wrote:
> This CL adds bidi support to the web-app. It will need checking more carefully
> by a native speaker once we have a RTL translation available, but for now PTAL
> to see if this conforms to best practice.
> 
>
http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.css
> File remoting/webapp/me2mom/choice.css (right):
> 
>
http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.c...
> remoting/webapp/me2mom/choice.css:19: direction: __MSG_@@bidi_dir__;
> I don't think we're supposed to use CSS to set text direction, but I don't
think
> Chrome extensions can use __MSG__ substitutions in the HTML. If you know of a
> better way of doing this, let me know.

LGTM

[garykac, 2011-08-10 19:34:37]

http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.css
File remoting/webapp/me2mom/choice.css (right):

http://codereview.chromium.org/7610001/diff/1/remoting/webapp/me2mom/choice.c...
remoting/webapp/me2mom/choice.css:19: direction: __MSG_@@bidi_dir__;
On 2011/08/10 18:24:31, Jamie wrote:
> I don't think we're supposed to use CSS to set text direction, but I don't
think
> Chrome extensions can use __MSG__ substitutions in the HTML. If you know of a
> better way of doing this, let me know.

This seems OK to me.