Issue 7609001: Enable ChromeVox on the OOBE screens when using the keyboard shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7609001: Enable ChromeVox on the OOBE screens when using the keyboard shortcut. (Closed)

Created:
9 years, 4 months ago by Zachary Kuznia

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Dominic at Gmail (DO NOT USE), dmazzoni

CC:
chromium-reviews, nkostylev+cc_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable ChromeVox on the OOBE screens when using the keyboard shortcut. R=dmazzoni BUG=chromium-os:14804 TEST=Press ctrl+alt+z on the OOBE screen to enable accessibility. Continue to the Terms of service page. Press tab to move focus to the DOM view. Press shift + space + down to navigate the EULA. Ensure that it's spoken. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96136

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code Review fix #

Patch Set 3 : Code review fix #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/chromeos/accessibility_util.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

LGTM. http://codereview.chromium.org/7609001/diff/1/chrome/browser/chromeos/login/wizard_accessibility_helper.cc File chrome/browser/chromeos/login/wizard_accessibility_helper.cc (left): http://codereview.chromium.org/7609001/diff/1/chrome/browser/chromeos/login/wizard_accessibility_helper.cc#oldcode116 chrome/browser/chromeos/login/wizard_accessibility_helper.cc:116: prefService->ScheduleSavePersistentPrefs(); Hey, I noticed that accessibility_util.cc doesn't ever ...

9 years, 4 months ago (2011-08-10 05:12:01 UTC) #2

commit-bot: I haz the power

9 years, 4 months ago (2011-08-10 05:50:02 UTC) #3

Can't apply patch for file
chrome/browser/chromeos/login/wizard_accessibility_helper.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/login/wizard_accessibility_helper.cc
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 110.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/login/wizard_accessibility_helper.cc.rej

Expand Messages | Collapse Messages