Issue 7608033: Move the refcounting from the proxy/impl resource object to the shared resource object base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7608033: Move the refcounting from the proxy/impl resource object to the shared resource object base class. (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Move the refcounting from the proxy/impl resource object to the shared resource object base class. Fix the audio and video code which shouldn't have derived from the ResourceObjectBase class. This produced a diamond inheritance on refcounted. The refcounting for resources is no longer threadsafe. We weren't doing any thread stuff with these, so this should be fine. There should be no behavior change. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96394

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -25 lines)			Patch
M	ppapi/proxy/plugin_resource.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	ppapi/shared_impl/audio_impl.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ppapi/shared_impl/audio_impl.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ppapi/shared_impl/resource_object_base.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/video_decoder_impl.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ppapi/shared_impl/video_decoder_impl.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/resource.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

Another easy one, this depends on http://codereview.chromium.org/7608030/

9 years, 4 months ago (2011-08-10 17:07:50 UTC) #1

yzshen1

9 years, 4 months ago (2011-08-10 17:35:19 UTC) #2

LGTM.

Thanks!

On 2011/08/10 17:07:50, brettw wrote:
> Another easy one, this depends on http://codereview.chromium.org/7608030/

Expand Messages | Collapse Messages