Issue 7608030: Convert the PluginResource to be refcounted.

Issue 7608030: Convert the PluginResource to be refcounted. (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Convert the PluginResource to be refcounted. This is to make the future transition to a shared resource tracker (which will use refcounted resources) easier. There should be no behavior change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96324

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -62 lines)			Patch
M	ppapi/proxy/plugin_resource.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_resource_tracker.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	ppapi/proxy/plugin_resource_tracker.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	ppapi/proxy/plugin_resource_tracker_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_config_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_broker_proxy.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_buffer_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_context_3d_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_file_chooser_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_file_ref_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_file_system_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_menu_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_net_connector_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_tcp_socket_proxy.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_2d_proxy.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_input_event_proxy.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_pdf_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_surface_3d_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_url_loader_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_url_request_info_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_url_response_info_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_video_capture_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_video_decoder_proxy.cc	View	1 chunk	+1 line, -3 lines	2 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yzshen1

LGTM Thanks! http://codereview.chromium.org/7608030/diff/1/ppapi/proxy/ppb_video_decoder_proxy.cc File ppapi/proxy/ppb_video_decoder_proxy.cc (right): http://codereview.chromium.org/7608030/diff/1/ppapi/proxy/ppb_video_decoder_proxy.cc#newcode78 ppapi/proxy/ppb_video_decoder_proxy.cc:78: scoped_ptr<VideoDecoder> decoder(new VideoDecoder(resource)); [nit, optional] you might ...

9 years, 4 months ago (2011-08-10 17:26:51 UTC) #2

brettw

9 years, 4 months ago (2011-08-10 17:40:28 UTC) #3

http://codereview.chromium.org/7608030/diff/1/ppapi/proxy/ppb_video_decoder_p...
File ppapi/proxy/ppb_video_decoder_proxy.cc (right):

http://codereview.chromium.org/7608030/diff/1/ppapi/proxy/ppb_video_decoder_p...
ppapi/proxy/ppb_video_decoder_proxy.cc:78: scoped_ptr<VideoDecoder> decoder(new
VideoDecoder(resource));
Phew, good catch!

Expand Messages | Collapse Messages