Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4322)

Unified Diff: build/common.gypi

Issue 7608027: Disable data page (heap) execution when running on Mac OS X 10.7 ("Lion") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 95997)
+++ build/common.gypi (working copy)
@@ -1660,6 +1660,23 @@
['_mac_bundle', {
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
}],
+ ['_type=="executable"', {
+ 'postbuilds': [
+ {
+ # Arranges for data (heap) pages to be protected against
+ # code execution when running on Mac OS X 10.7 ("Lion").
+ 'variables': {
+ # Define make_heap_non_executable in a variable ending in
+ # _path so that gyp understands it's a path and performs
+ # proper relativization during dict merging.
+ 'make_heap_non_executable_path':
+ 'mac/make_heap_non_executable_from_xcode.sh',
+ },
+ 'postbuild_name': 'Make Heap Non-Executable',
+ 'action': ['<(make_heap_non_executable_path)'],
+ },
+ ],
+ }],
['_type=="executable" and release_valgrind_build==0', {
# Turn on position-independence (ASLR) for executables. When PIE
# is on for the Chrome executables, the framework will also be
« no previous file with comments | « no previous file | build/mac/make_heap_non_executable.py » ('j') | build/mac/make_heap_non_executable_from_xcode.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698