build/mac/make_heap_non_executable_from_xcode.sh - Issue 7608027: Disable data page (heap) execution when running on Mac OS X 10.7 ("Lion")

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/mac/make_heap_non_executable_from_xcode.sh

Issue 7608027: Disable data page (heap) execution when running on Mac OS X 10.7 ("Lion") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:executable
+ *
Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 # This is a small wrapper script around make_heap_non_executable.py allowing

	8 # it to be invoked easily from Xcode. make_heap_non_executable.py expects its

	9 # argument on the command line, and Xcode puts all of its parameters in the

	10 # environment.

	11

	12 set -e

	13
	TVL 2011/08/10 16:02:11 do you want to check the sdk here and warn/error i do you want to check the sdk here and warn/error if we're using the 10.7 sdk since that's probably the safest way to assume we should be using the xcode_setting support instead? Mark Mentovai 2011/08/10 16:05:04 TVL wrote: TVL wrote: Show quoted text > do you want to check the sdk here and warn/error if we're using the 10.7 sdk > since that's probably the safest way to assume we should be using the > xcode_setting support instead? 1. There is no xcode_settings support. The linker default as of Xcode 4.0 (note, 4.0 on 10.6, not 4.1 on 10.7) is to set MH_NO_HEAP_EXECUTION when creating an i386 executable. Use -allow_heap_execute to DISABLE setting this bit. 2. As mentioned in the script, the linker ONLY does this for i386 executables, not x86_64 executables. I want to (eventually) set the bit on x86_64 executables as well to cover a corner case.
	14 exec "$(dirname "${0}")/make_heap_non_executable.py" \

	15 "${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}"

OLD	NEW

« no previous file with comments | « build/mac/make_heap_non_executable.py ('k') | no next file » | no next file with comments »