Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 7608019: Remove ibus-hangul support. (Closed)

Created:
9 years, 4 months ago by Yusuke Sato
Modified:
9 years, 4 months ago
Reviewers:
mazda, Seigo Nonaka
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove ibus-hangul support. BUG=None TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96168

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuke Sato
adding mazda since nona is not a chromium committer yet.
9 years, 4 months ago (2011-08-10 08:46:55 UTC) #1
mazda
LGTM
9 years, 4 months ago (2011-08-10 08:48:27 UTC) #2
Seigo Nonaka
http://codereview.chromium.org/7608019/diff/1/chrome/browser/chromeos/language_preferences.cc File chrome/browser/chromeos/language_preferences.cc (right): http://codereview.chromium.org/7608019/diff/1/chrome/browser/chromeos/language_preferences.cc#newcode146 chrome/browser/chromeos/language_preferences.cc:146: const char kHangulHanjaKeysConfigName[] = "HanjaKeys"; Sorry I forget add ...
9 years, 4 months ago (2011-08-10 08:53:13 UTC) #3
Yusuke Sato
http://codereview.chromium.org/7608019/diff/1/chrome/browser/chromeos/language_preferences.cc File chrome/browser/chromeos/language_preferences.cc (right): http://codereview.chromium.org/7608019/diff/1/chrome/browser/chromeos/language_preferences.cc#newcode146 chrome/browser/chromeos/language_preferences.cc:146: const char kHangulHanjaKeysConfigName[] = "HanjaKeys"; good point. Fixed. On ...
9 years, 4 months ago (2011-08-10 09:18:48 UTC) #4
Yusuke Sato
PTAL On 2011/08/10 09:18:48, Yusuke Sato wrote: > http://codereview.chromium.org/7608019/diff/1/chrome/browser/chromeos/language_preferences.cc > File chrome/browser/chromeos/language_preferences.cc (right): > > ...
9 years, 4 months ago (2011-08-10 09:22:43 UTC) #5
Seigo Nonaka
LGTM
9 years, 4 months ago (2011-08-10 11:04:22 UTC) #6
mazda
9 years, 4 months ago (2011-08-10 11:08:08 UTC) #7
LGTM again

Powered by Google App Engine
This is Rietveld 408576698