Handle inconsistency between DB and Files

webkit/fileapi/sandbox_mount_point_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/sandbox_mount_point_provider.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_callback_factory.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 602 matching lines @@
 
 void SandboxMountPointProvider::EndUpdateOriginOnFileThread(
     const GURL& origin_url, fileapi::FileSystemType type) {
   DCHECK(type == fileapi::kFileSystemTypeTemporary ||
          type == fileapi::kFileSystemTypePersistent);
   FilePath usage_file_path = GetUsageCachePathForOriginAndType(
       origin_url, type);
   FileSystemUsageCache::DecrementDirty(usage_file_path);
 }
 
+void SandboxMountPointProvider::ScheduleRecalculateUsage(
+    const GURL& origin_url, fileapi::FileSystemType type) {
+  StartUpdateOriginOnFileThread(origin_url, type);

[ericu, 2011/08/17 00:54:08]

This doesn't actually start an update--it just marks the file to say there's one
in progress.

[tzik, 2011/08/18 08:02:26]

Actually, what I want to do in here is to increment the dirty count for the
origin and the type.
It'll force SMPP to recalculate usage at next initialization time.

[ericu, 2011/08/19 04:05:56]

What about just deleting the usage cache file?  Or would that cause other
problems?

[tzik, 2011/08/23 04:13:13]

If some write-operation are running, they breaks dirty count at completion
without .usage file.
How about adding validity flag to .usage to mark it invalid, like patchset 5?

+}
+
 FileSystemFileUtil* SandboxMountPointProvider::GetFileSystemFileUtil() {
   return sandbox_file_util_.get();
 }
 
 FilePath SandboxMountPointProvider::GetUsageCachePathForOriginAndType(
     const GURL& origin_url, fileapi::FileSystemType type) const {
   FilePath base_path =
       GetBaseDirectoryForOriginAndType(origin_url, type, false);
   if (base_path.empty())
     return FilePath();
@@ skipping 19 matching lines @@
 
   // Creates the root directory.
   root = origin_base_path.Append(OldCreateUniqueDirectoryName(origin_url));
   if (!file_util::CreateDirectory(root))
     return FilePath();
 
   return root;
 }
 
 }  // namespace fileapi