When determining whether or not to swap processes on navigation, check the top frame's URL.

When determining whether or not to swap processes on navigation, check the top frame's URL.
Otherwise having an inner frame that matches the app's extent could mean that the process
is not swapped, even if we're not in an app process.

Difference from r94843 is that the popup window is 200x200, so that it results in a separate
Browser instance even on Chrome OS.

BUG=89272
TEST=no
R=creis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96197

[Mihai Parparita -not on Chrome, 2011-08-10 04:04:37]

Tryjob appears to have passed:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...

Mihai

On Tue, Aug 9, 2011 at 6:37 PM,  <mihaip@chromium.org> wrote:
> Reviewers: creis,
>
> Description:
> When determining whether or not to swap processes on navigation, check the
> top
> frame's URL.
> Otherwise having an inner frame that matches the app's extent could mean
> that
> the process
> is not swapped, even if we're not in an app process.
>
> Difference from r94843 is that the popup window is 200x200, so that it
> results
> in a separate
> Browser instance even on Chrome OS.
>
> BUG=89272
> TEST=no
> R=creis@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7608015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/extensions/app_process_apitest.cc
>  M chrome/renderer/chrome_content_renderer_client.cc
>  A chrome/test/data/extensions/api_test/app_process/path1/iframe.html
>  A chrome/test/data/extensions/api_test/app_process/path3/container.html
>
>
>

[Charlie Reis, 2011-08-10 17:08:16]

Great-- LGTM.