Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: webkit/fileapi/quota_file_util.h

Issue 7608011: Simplify directory path accounting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rolled in CR feedback. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/obfuscated_file_system_file_util_unittest.cc ('k') | webkit/fileapi/quota_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/quota_file_util.h
diff --git a/webkit/fileapi/quota_file_util.h b/webkit/fileapi/quota_file_util.h
index efad64f1556e26a633bccce07e4d402d6931e789..991497b7dfe52b799971fac9bdfe9ed6b824a9a2 100644
--- a/webkit/fileapi/quota_file_util.h
+++ b/webkit/fileapi/quota_file_util.h
@@ -29,25 +29,6 @@ class QuotaFileUtil : public FileSystemFileUtil {
// instance.
static QuotaFileUtil* CreateDefault();
- // TODO(dmikurube): Make this function variable by the constructor.
- int64 ComputeFilePathCost(const FilePath& file_path) const;
-
- virtual base::PlatformFileError CreateOrOpen(
- FileSystemOperationContext* fs_context,
- const FilePath& file_path, int file_flags,
- PlatformFile* file_handle, bool* created) OVERRIDE;
-
- virtual base::PlatformFileError EnsureFileExists(
- FileSystemOperationContext* fs_context,
- const FilePath& file_path,
- bool* created) OVERRIDE;
-
- virtual base::PlatformFileError CreateDirectory(
- FileSystemOperationContext* fs_context,
- const FilePath& file_path,
- bool exclusive,
- bool recursive) OVERRIDE;
-
virtual base::PlatformFileError CopyOrMoveFile(
FileSystemOperationContext* fs_context,
const FilePath& src_file_path,
@@ -58,10 +39,6 @@ class QuotaFileUtil : public FileSystemFileUtil {
FileSystemOperationContext* fs_context,
const FilePath& file_path) OVERRIDE;
- virtual base::PlatformFileError DeleteSingleDirectory(
- FileSystemOperationContext* fs_context,
- const FilePath& file_path) OVERRIDE;
-
virtual base::PlatformFileError Truncate(
FileSystemOperationContext* fs_context,
const FilePath& path,
@@ -70,25 +47,6 @@ class QuotaFileUtil : public FileSystemFileUtil {
private:
scoped_ptr<FileSystemFileUtil> underlying_file_util_;
- // TODO(dmikurube): Make these constants variable by the constructor.
- //
- // These values are based on Obfuscation DB. See crbug.com/86114 for the
- // source of these numbers. These should be revisited if
- // * the underlying tables change,
- // * indexes in levelDB change, or
- // * another path name indexer is provided in addition to levelDB.
- //
- // When these values are changed, the usage cache should be bumped up.
- static const int64 kFilePathCostPerChar;
- static const int64 kFilePathCostPerFile;
-
- bool CanCopyFile(
- FileSystemOperationContext* fs_context,
- const FilePath& src_file_path,
- const FilePath& dest_file_path,
- int64 allowed_bytes_growth,
- int64* growth) const;
-
DISALLOW_COPY_AND_ASSIGN(QuotaFileUtil);
};
« no previous file with comments | « webkit/fileapi/obfuscated_file_system_file_util_unittest.cc ('k') | webkit/fileapi/quota_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698