CrOS - Memory debug widget shows anonymous memory and renderer kills.

CrOS - Memory debug widget shows anonymous memory and renderer kills.

Change the status area memory widget to display anonymous memory allocated,
which is a good proxy for "total memory allocated" and what we use in the 
UMA histograms (Platform.MemuseAnon[0-5]).  Also display renderer kills, which
will tick up when we run out of memory and the OOM killer starts running.
Refactor GetSystemMemoryInfo to use a struct.

BUG=chromium-os:18969
TEST=manual, turn on memory status widget in about:flags and restart, open some tabs and watch memory consumption increase, use Task Manager / End Process to kill a process and watch the kill count increase

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96423

[James Cook, 2011-08-10 17:28:17]

Steven, please have a look at memory_menu_button.*

Darin, please have a look at base/process_util*.  Basically I converted
GetSystemMemoryInfo to take a pointer to a struct instead of a long list of
parameters, and added a couple other memory stats so I can compute anonymous
memory consumption.

[darin (slow to review), 2011-08-10 18:03:04]

LGTM

[stevenjb, 2011-08-10 19:45:51]

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/memory_menu_button.cc (right):

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.cc:64: std::wstring label =
base::StringPrintf(L"%d MB / %d",
nit: maybe (%d) instead? Do we want to only show number of kills if > 0?

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/memory_menu_button.h (right):

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.h:18: class
SystemMemoryInfoKB;
struct

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.h:71:
base::SystemMemoryInfoKB* meminfo_;
scoped_ptr<>

[James Cook, 2011-08-10 22:07:52]

Steven, comments addressed.

Darin, no changes to base/* from previous.

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/memory_menu_button.cc (right):

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.cc:64: std::wstring label =
base::StringPrintf(L"%d MB / %d",
On 2011/08/10 19:45:51, Steven Bennetts wrote:
> nit: maybe (%d) instead? Do we want to only show number of kills if > 0?

Done.

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/memory_menu_button.h (right):

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.h:18: class
SystemMemoryInfoKB;
On 2011/08/10 19:45:51, Steven Bennetts wrote:
> struct

Done.

http://codereview.chromium.org/7607035/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/memory_menu_button.h:71:
base::SystemMemoryInfoKB* meminfo_;
On 2011/08/10 19:45:51, Steven Bennetts wrote:
> scoped_ptr<>

Done.

[stevenjb, 2011-08-10 23:34:29]

LGTM