Options: Two fixes for Autofill lists.

chrome/browser/resources/options/autofill_options_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.autofillOptions', function() {
   const DeletableItem = options.DeletableItem;
   const DeletableItemList = options.DeletableItemList;
   const InlineEditableItem = options.InlineEditableItem;
   const InlineEditableItemList = options.InlineEditableItemList;
 
@@ skipping 151 matching lines @@
 
     /**
      * Called when committing an edit.  Committing a non-empty value adds it
      * to the end of the values list, leaving this "AddRow" in place.
      * @param {Event} e The end event.
      * @extends {options.ValuesListItem}
      * @private
      */
     onEditCommitted_: function(e) {
       var i = this.list.items.indexOf(this);
-      if (i < 0 || i >= this.list.dataModel.length)
+      if (i < 0 || i >= this.list.dataModel.length || !this.input.value.length)
         return;
 
       if (this.input.value &&
           this.list.dataModel.indexOf(this.input.value) == -1) {
         // It is important that updateIndex is done before validateAndSave.
         // Otherwise we can not be sure about AddRow index.
         this.list.dataModel.updateIndex(i);
         this.list.validateAndSave(i, 0, this.input.value);
       } else {
         this.input.value = '';
-        this.list.dataModel.updateIndex(i);
       }
     },
   };
 
   /**
    * Create a new address list.
    * @constructor
    * @extends {options.DeletableItemList}
    */
   var AutofillAddressList = cr.ui.define('list');
@@ skipping 106 matching lines @@
         return new ValuesListItem(this, entry);
       else
         return new ValuesAddRowListItem(this);
     },
 
     /** @inheritDoc */
     deleteItemAtIndex: function(index) {
       this.dataModel.splice(index, 1);
     },
 
+    /** @inheritDoc */
+    shouldFocusPlaceholder: function() {

[csilv, 2011/08/10 17:55:25]

odd that we consider "placeholder" a word?  not suggesting that we change it,
but just pointing it out.

+      return false;
+    },
+
     /**
      * Called when a new list item should be validated; subclasses are
      * responsible for implementing if validation is required.
      * @param {number} index The index of the item that was inserted or changed.
      * @param {number} remove The number items to remove.
      * @param {string} value The value of the item to insert.
      */
     validateAndSave: function(index, remove, value) {
       this.dataModel.splice(index, remove, value);
     },
@@ skipping 56 matching lines @@
     CreditCardListItem: CreditCardListItem,
     ValuesListItem: ValuesListItem,
     ValuesAddRowListItem: ValuesAddRowListItem,
     AutofillAddressList: AutofillAddressList,
     AutofillCreditCardList: AutofillCreditCardList,
     AutofillValuesList: AutofillValuesList,
     AutofillPhoneValuesList: AutofillPhoneValuesList,
     AutofillFaxValuesList: AutofillFaxValuesList,
   };
 });