Issue 7607027: Options: Two fixes for Autofill lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7607027: Options: Two fixes for Autofill lists. (Closed)

Created:
9 years, 4 months ago by James Hawkins

Modified:
9 years, 4 months ago

Reviewers:
csilv, commit-bot: I haz the power, Ilya Sherman

CC:
chromium-reviews, GeorgeY, arv (Not doing code reviews), dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Options: Two fixes for Autofill lists. * Don't update the model if no entry is committed. * Don't focus the placeholder for AF lists, since it doesn't particularly make sense to add a second name right away. BUG=92237 TEST=none R=csilv@chromium.org

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/autofill_options_list.js	View		3 chunks	+6 lines, -2 lines	1 comment	Download
	M	chrome/browser/resources/options/inline_editable_list.js	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/7607027/diff/1/chrome/browser/resources/options/autofill_options_list.js File chrome/browser/resources/options/autofill_options_list.js (right): http://codereview.chromium.org/7607027/diff/1/chrome/browser/resources/options/autofill_options_list.js#newcode310 chrome/browser/resources/options/autofill_options_list.js:310: shouldFocusPlaceholder: function() { odd that we consider "placeholder" ...

9 years, 4 months ago (2011-08-10 17:55:25 UTC) #2

commit-bot: I haz the power

Can't apply patch for file chrome/browser/resources/options/autofill_options_list.js. While running patch -p1 --forward --force; patching file chrome/browser/resources/options/autofill_options_list.js ...

9 years, 4 months ago (2011-08-10 19:51:19 UTC) #3

Looks like this was committed.  Closing...

Expand Messages | Collapse Messages