Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 7607019: [ChromeOS] Reset Gaia UI and show error if needed. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[ChromeOS] Reset Gaia UI and show error if needed. There are cases where Gaia authentication passed but login still fails, e.g. using a valid Google account that is not in whitelist. We want to reset Gaia UI with an error message when this happens. BUG=chromium-os:18801 TEST=Verify fix for chromium-os:18801. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -13 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/bubble.js View 2 chunks +23 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 4 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-09 23:04:06 UTC) #1
achuithb
LGTM.
9 years, 4 months ago (2011-08-09 23:49:38 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 05:39:18 UTC) #3
Change committed as 96133

Powered by Google App Engine
This is Rietveld 408576698