Remove PREVIOUS_GRAPHEME_TRAILING.

views/controls/textfield/textfield_views_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/clipboard/clipboard.h"
@@ skipping 108 matching lines @@
   EXPECT_EQ(string16(), model.GetSelectedText());
   model.SelectAll();
   EXPECT_STR_EQ("HELLO", model.GetSelectedText());
   // SelectAll should select towards the end.
   ui::Range range;
   model.GetSelectedRange(&range);
   EXPECT_EQ(0U, range.start());
   EXPECT_EQ(5U, range.end());
 
   // Select and move cursor
   gfx::SelectionModel selection(1U);

[msw, 2011/08/13 19:37:38]

These two lines are no longer necessary.

   model.MoveCursorTo(selection);
-  selection.set_selection_end(3U);
+  selection = gfx::SelectionModel(1U, 3U);

[msw, 2011/08/13 19:37:38]

You can optionally get rid of |selection| and just construct SelectionModels in
the calls to MoveCursorTo.

   model.MoveCursorTo(selection);
   EXPECT_STR_EQ("EL", model.GetSelectedText());
   model.MoveCursorLeft(gfx::CHARACTER_BREAK, false);
   EXPECT_EQ(1U, model.GetCursorPosition());
-  selection.set_selection_end(1U);
-  selection.set_selection_start(selection.selection_end());
+  selection = gfx::SelectionModel(1U);
   model.MoveCursorTo(selection);
-  selection.set_selection_end(3U);
+  selection = gfx::SelectionModel(1U, 3U);
   model.MoveCursorTo(selection);
   model.MoveCursorRight(gfx::CHARACTER_BREAK, false);
   EXPECT_EQ(3U, model.GetCursorPosition());
 
   // Select all and move cursor
   model.SelectAll();
   model.MoveCursorLeft(gfx::CHARACTER_BREAK, false);
   EXPECT_EQ(0U, model.GetCursorPosition());
   model.SelectAll();
   model.MoveCursorRight(gfx::CHARACTER_BREAK, false);
@@ skipping 185 matching lines @@
   model.SelectWord();
   SelectWordTestVerifier(model, "  ", 2U);
 
   // Test when cursor is at the beginning of a word.
   gfx::SelectionModel selection(2U);
   model.MoveCursorTo(selection);
   model.SelectWord();
   SelectWordTestVerifier(model, "HELLO", 7U);
 
   // Test when cursor is at the end of a word.
-  selection.set_selection_end(15U);
-  selection.set_selection_start(selection.selection_end());
+  selection = gfx::SelectionModel(15U);
   model.MoveCursorTo(selection);
   model.SelectWord();
   SelectWordTestVerifier(model, "WO", 15U);
 
   // Test when cursor is somewhere in a non-alph-numeric fragment.
   for (size_t cursor_pos = 8; cursor_pos < 13U; cursor_pos++) {
-    selection.set_selection_end(cursor_pos);
-    selection.set_selection_start(selection.selection_end());
+    selection = gfx::SelectionModel(cursor_pos);
     model.MoveCursorTo(selection);
     model.SelectWord();
     SelectWordTestVerifier(model, "  !!  ", 13U);
   }
 
   // Test when cursor is somewhere in a whitespace fragment.
-  selection.set_selection_end(17U);
-  selection.set_selection_start(selection.selection_end());
+  selection = gfx::SelectionModel(17U);
   model.MoveCursorTo(selection);
   model.SelectWord();
   SelectWordTestVerifier(model, "     ", 20U);
 
   // Test when cursor is at the end.
   model.MoveCursorRight(gfx::LINE_BREAK, false);
   model.SelectWord();
   SelectWordTestVerifier(model, " ", 24U);
 }
 
@@ skipping 429 matching lines @@
   EXPECT_STR_EQ("www.youtube.com", model.GetText());
   EXPECT_EQ(5U, model.GetCursorPosition());
   EXPECT_FALSE(model.Redo());
 }
 
 TEST_F(TextfieldViewsModelTest, UndoRedo_CutCopyPasteTest) {
   TextfieldViewsModel model(NULL);
   model.SetText(ASCIIToUTF16("ABCDE"));
   EXPECT_FALSE(model.Redo());  // nothing to redo
   // Cut
   gfx::SelectionModel sel(1);

[msw, 2011/08/13 19:37:38]

You can remove these two lines.

   model.MoveCursorTo(sel);
-  sel.set_selection_end(3);
+  sel = gfx::SelectionModel(1, 3);
   model.MoveCursorTo(sel);
   model.Cut();
   EXPECT_STR_EQ("ADE", model.GetText());
   EXPECT_EQ(1U, model.GetCursorPosition());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.GetText());
   EXPECT_EQ(3U, model.GetCursorPosition());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.GetText());
   EXPECT_EQ(0U, model.GetCursorPosition());
@@ skipping 66 matching lines @@
   // empty cut shouldn't create an edit.
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCBCBCDE", model.GetText());
   EXPECT_EQ(3U, model.GetCursorPosition());
 
   // Copy
   ResetModel(&model);
   model.SetText(ASCIIToUTF16("12345"));
   EXPECT_STR_EQ("12345", model.GetText());
   EXPECT_EQ(0U, model.GetCursorPosition());
   sel.set_selection_end(1);

[msw, 2011/08/13 19:37:38]

You can remove these three lines.

   sel.set_selection_start(sel.selection_end());
   model.MoveCursorTo(sel);
-  sel.set_selection_end(3);
+  sel = gfx::SelectionModel(1, 3);
   model.MoveCursorTo(sel);
   model.Copy();  // Copy "23"
   EXPECT_STR_EQ("12345", model.GetText());
   EXPECT_EQ(3U, model.GetCursorPosition());
   model.Paste();  // Paste "23" into "23".
   EXPECT_STR_EQ("12345", model.GetText());
   EXPECT_EQ(3U, model.GetCursorPosition());
   model.Paste();
   EXPECT_STR_EQ("1232345", model.GetText());
   EXPECT_EQ(5U, model.GetCursorPosition());
@@ skipping 104 matching lines @@
   EXPECT_EQ(5U, model.GetCursorPosition());
   EXPECT_FALSE(model.Redo());
 }
 
 TEST_F(TextfieldViewsModelTest, UndoRedo_ReplaceTest) {
   // By Cursor
   {
     SCOPED_TRACE("forward & insert by cursor");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     gfx::SelectionModel sel(1);

[msw, 2011/08/13 19:37:38]

You can remove these two lines.

     model.MoveCursorTo(sel);
-    sel.set_selection_end(3);
+    sel = gfx::SelectionModel(1, 3);
     model.MoveCursorTo(sel);
     RunInsertReplaceTest(model);
   }
   {
     SCOPED_TRACE("backward & insert by cursor");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     gfx::SelectionModel sel(3);

[msw, 2011/08/13 19:37:38]

You can remove these two lines.

     model.MoveCursorTo(sel);
-    sel.set_selection_end(1);
+    sel = gfx::SelectionModel(3, 1);
     model.MoveCursorTo(sel);
     RunInsertReplaceTest(model);
   }
   {
     SCOPED_TRACE("forward & overwrite by cursor");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     gfx::SelectionModel sel(1);

[msw, 2011/08/13 19:37:38]

You can remove these two lines.

     model.MoveCursorTo(sel);
-    sel.set_selection_end(3);
+    sel = gfx::SelectionModel(1, 3);
     model.MoveCursorTo(sel);
     RunOverwriteReplaceTest(model);
   }
   {
     SCOPED_TRACE("backward & overwrite by cursor");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     gfx::SelectionModel sel(3);

[msw, 2011/08/13 19:37:38]

You can remove these two lines.

     model.MoveCursorTo(sel);
-    sel.set_selection_end(1);
+    sel = gfx::SelectionModel(3, 1);
     model.MoveCursorTo(sel);
     RunOverwriteReplaceTest(model);
   }
   // By SelectRange API
   {
     SCOPED_TRACE("forward & insert by SelectRange");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     model.SelectRange(ui::Range(1, 3));
     RunInsertReplaceTest(model);
@@ skipping 92 matching lines @@
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.GetText());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("1234", model.GetText());
   EXPECT_FALSE(model.Redo());
 
   // TODO(oshima): We need MockInputMethod to test the behavior with IME.
 }
 
 }  // namespace views