Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 7607014: Fix sporadic crash at the end of gles2 ppapi plugin (Closed)

Created:
9 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix sporadic crash at the end of gles2 ppapi plugin Fix plugin so that frames can still be painted after the decoder has been destroyed. BUG=NONE TEST=gles2 consistently runs without crashing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96196

Patch Set 1 #

Total comments: 2

Patch Set 2 : address CR comments #

Patch Set 3 : adding OWNERS for gles2.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
A ppapi/examples/gles2/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/examples/gles2/gles2.cc View 1 2 5 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vrk (LEFT CHROMIUM)
PictureReady() was still being called after the DecoderFlushDone() destroyed the video_decoder_ field. However, it wasn't ...
9 years, 4 months ago (2011-08-09 22:14:58 UTC) #1
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/7607014/diff/1/ppapi/examples/gles2/gles2.cc File ppapi/examples/gles2/gles2.cc (right): http://codereview.chromium.org/7607014/diff/1/ppapi/examples/gles2/gles2.cc#newcode396 ppapi/examples/gles2/gles2.cc:396: void GLES2DemoInstance::Render(const PP_PictureBuffer_Dev& buffer) { From offline convo: - ...
9 years, 4 months ago (2011-08-09 22:25:16 UTC) #2
vrk (LEFT CHROMIUM)
http://codereview.chromium.org/7607014/diff/1/ppapi/examples/gles2/gles2.cc File ppapi/examples/gles2/gles2.cc (right): http://codereview.chromium.org/7607014/diff/1/ppapi/examples/gles2/gles2.cc#newcode396 ppapi/examples/gles2/gles2.cc:396: void GLES2DemoInstance::Render(const PP_PictureBuffer_Dev& buffer) { On 2011/08/09 22:25:16, Ami ...
9 years, 4 months ago (2011-08-09 22:44:39 UTC) #3
Ami GONE FROM CHROMIUM
LGTM
9 years, 4 months ago (2011-08-09 23:02:12 UTC) #4
vrk (LEFT CHROMIUM)
+brettw OWNERS review? Also added OWNERS file in the gles2 directory.
9 years, 4 months ago (2011-08-09 23:09:33 UTC) #5
brettw
9 years, 4 months ago (2011-08-10 16:00:10 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698