[Sync] Fix sync proto files to better match server versions

[Sync] Fix sync proto files to better match server versions

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96134

[akalin, 2011-08-09 21:30:46]

+tim for review

[tim (not reviewing), 2011-08-09 22:30:11]

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/au...
File chrome/browser/sync/protocol/autofill_specifics.proto (right):

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/au...
chrome/browser/sync/protocol/autofill_specifics.proto:48: message
AutofillCreditCardSpecifics {
sigh.. given that this was never used by a single client build, I wonder if we
could remove it.  don't mean to rope you in :)

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/ni...
File chrome/browser/sync/protocol/nigori_specifics.proto (right):

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/ni...
chrome/browser/sync/protocol/nigori_specifics.proto:49: // optional bool
deprecated_encrypt_search_engines = 12;
are these commented out server-side as well?

[akalin, 2011-08-10 00:49:53]

PTAL

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/au...
File chrome/browser/sync/protocol/autofill_specifics.proto (right):

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/au...
chrome/browser/sync/protocol/autofill_specifics.proto:48: message
AutofillCreditCardSpecifics {
On 2011/08/09 22:30:11, timsteele wrote:
> sigh.. given that this was never used by a single client build, I wonder if we
> could remove it.  don't mean to rope you in :)

I can do this in a separate CL.

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/ni...
File chrome/browser/sync/protocol/nigori_specifics.proto (right):

http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/ni...
chrome/browser/sync/protocol/nigori_specifics.proto:49: // optional bool
deprecated_encrypt_search_engines = 12;
On 2011/08/09 22:30:11, timsteele wrote:
> are these commented out server-side as well?

Yes.

[tim (not reviewing), 2011-08-10 00:53:36]

LGTM

On Tue, Aug 9, 2011 at 5:49 PM, <akalin@chromium.org> wrote:

> PTAL
>
>
>
> http://codereview.chromium.**org/7607012/diff/1/chrome/**
>
browser/sync/protocol/**autofill_specifics.proto<http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/autofill_specifics.proto>
> File chrome/browser/sync/protocol/**autofill_specifics.proto (right):
>
> http://codereview.chromium.**org/7607012/diff/1/chrome/**
>
browser/sync/protocol/**autofill_specifics.proto#**newcode48<http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/autofill_specifics.proto#newcode48>
> chrome/browser/sync/protocol/**autofill_specifics.proto:48: message
> AutofillCreditCardSpecifics {
> On 2011/08/09 22:30:11, timsteele wrote:
>
>> sigh.. given that this was never used by a single client build, I
>>
> wonder if we
>
>> could remove it.  don't mean to rope you in :)
>>
>
> I can do this in a separate CL.
>
>
> http://codereview.chromium.**org/7607012/diff/1/chrome/**
>
browser/sync/protocol/nigori_**specifics.proto<http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/nigori_specifics.proto>
> File chrome/browser/sync/protocol/**nigori_specifics.proto (right):
>
> http://codereview.chromium.**org/7607012/diff/1/chrome/**
>
browser/sync/protocol/nigori_**specifics.proto#newcode49<http://codereview.chromium.org/7607012/diff/1/chrome/browser/sync/protocol/nigori_specifics.proto#newcode49>
> chrome/browser/sync/protocol/**nigori_specifics.proto:49: // optional bool
> deprecated_encrypt_search_**engines = 12;
> On 2011/08/09 22:30:11, timsteele wrote:
>
>> are these commented out server-side as well?
>>
>
> Yes.
>
>
>
http://codereview.chromium.**org/7607012/<http://codereview.chromium.org/7607...
>

[commit-bot: I haz the power, 2011-08-10 05:45:47]

Change committed as 96134