[ChromeOS] Freezes WebUI OOBE/Login window until tab is rendered.

[ChromeOS] Freezes WebUI OOBE/Login window until tab is rendered.

Manually unfreezes hosting window until WebUI OOBE/Login tab is rendered the first time to avoid the white screen when transitioning from boot splash.

This CL is based Oshima's r88345 and I have left a TODO to merge the logic.

BUG=chromium-os:18501
TEST=Verify fix for chromium-os:18501.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96132

[Daniel Erat, 2011-08-09 21:31:24]

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/webui_login_view.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:134: bool host_window_freezed_;
nit: s/freezed/frozen/

[achuithb, 2011-08-09 21:33:32]

LGTM with nits.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/webui_login_view.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:93: //
TabFirstRenderWatcher::Delegate implementation
period at end of comment.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:94: void OnTabMainFrameLoaded()
OVERRIDE;
Should be virtual, right? Same for method below.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:134: bool host_window_freezed_;
frozen? host_window_frozen_?

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
File chrome/browser/chromeos/tab_first_render_watcher.cc (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
chrome/browser/chromeos/tab_first_render_watcher.cc:54: }  // namespace chrmoeos
chromeos

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
File chrome/browser/chromeos/tab_first_render_watcher.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
chrome/browser/chromeos/tab_first_render_watcher.h:31: virtual void Observe(int
type,
Should this be protected?

[xiyuan, 2011-08-09 23:08:25]

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/webui_login_view.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:93: //
TabFirstRenderWatcher::Delegate implementation
On 2011/08/09 21:33:32, achuith.bhandarkar wrote:
> period at end of comment.

Done.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:94: void OnTabMainFrameLoaded()
OVERRIDE;
On 2011/08/09 21:33:32, achuith.bhandarkar wrote:
> Should be virtual, right? Same for method below.

Done.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_login_view.h:134: bool host_window_freezed_;
On 2011/08/09 21:33:32, achuith.bhandarkar wrote:
> frozen? host_window_frozen_?

Done.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
File chrome/browser/chromeos/tab_first_render_watcher.cc (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
chrome/browser/chromeos/tab_first_render_watcher.cc:54: }  // namespace chrmoeos
On 2011/08/09 21:33:32, achuith.bhandarkar wrote:
> chromeos

Done.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
File chrome/browser/chromeos/tab_first_render_watcher.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
chrome/browser/chromeos/tab_first_render_watcher.h:31: virtual void Observe(int
type,
On 2011/08/09 21:33:32, achuith.bhandarkar wrote:
> Should this be protected? 

Putting in private would force caller to use proper pointer to call it. That is,
calling Observe on a TabFirstRenderWatcher pointer directly is not allowed and
has to be called via a NotificationObserver pointer.

[achuithb, 2011-08-09 23:45:00]

LGTM still.

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
File chrome/browser/chromeos/tab_first_render_watcher.h (right):

http://codereview.chromium.org/7607011/diff/1/chrome/browser/chromeos/tab_fir...
chrome/browser/chromeos/tab_first_render_watcher.h:31: virtual void Observe(int
type,
Sounds good.

[commit-bot: I haz the power, 2011-08-10 05:39:01]

Change committed as 96132