Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/autocomplete/extension_app_provider.cc

Issue 7607007: Add confidence to AutocompleteMatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/extension_app_provider.cc
diff --git a/chrome/browser/autocomplete/extension_app_provider.cc b/chrome/browser/autocomplete/extension_app_provider.cc
index 0a68e8c96add51216b46c79cbf6edbde6663a370..8fef3a5391337543e92a1bfcd0952a4c68f3637b 100644
--- a/chrome/browser/autocomplete/extension_app_provider.cc
+++ b/chrome/browser/autocomplete/extension_app_provider.cc
@@ -56,7 +56,11 @@ void ExtensionAppProvider::Start(const AutocompleteInput& input,
// We have a match, might be a partial match.
// TODO(finnur): Figure out what type to return here, might want to have
// the extension icon/a generic icon show up in the Omnibox.
- AutocompleteMatch match(this, 0, false,
+ // TODO(dominich): Confidence would require us to create a match set and
+ // then iterate over to create the AutocompleteMatch objects. Currently
+ // confidence is used for instant/prerender/DNS preconnect and we may
+ // not want to do those for extension apps anyway.
+ AutocompleteMatch match(this, 0, 0.0f, false,
AutocompleteMatch::EXTENSION_APP);
match.fill_into_edit = url;
match.destination_url = GURL(url);
« no previous file with comments | « chrome/browser/autocomplete/builtin_provider.cc ('k') | chrome/browser/autocomplete/history_contents_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698