Issue 7607003: Split ExtensionWebRequestApiTest.WebRequestEvents into multiple tests to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7607003: Split ExtensionWebRequestApiTest.WebRequestEvents into multiple tests to (Closed)

Created:
9 years, 4 months ago by Matt Perry

Modified:
9 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Split ExtensionWebRequestApiTest.WebRequestEvents into multiple tests to fix flakiness. BUG=91715 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96075

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+969 lines, -1052 lines)			Patch
M	chrome/browser/extensions/extension_webrequest_apitest.cc	View	1 chunk	+21 lines, -10 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/api/manifest.json	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/api/test.html	View	1 chunk	+0 lines, -90 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/complexLoad/a.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/complexLoad/b.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/complexLoad/b.jpg	View	Binary file		0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/complexLoad/a.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/complexLoad/b.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/complexLoad/b.jpg	View	Binary file		0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/manifest.json	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/simpleLoad/a.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/test.html	View	1 chunk	+0 lines, -928 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/xhr/a.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webrequest/events/xhr/data.json	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/framework.js	View	1 chunk	+237 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/simpleLoad/a.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/test_api.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/test_blocking.html	View	1 chunk	+179 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/test_complex.html	View	1 chunk	+353 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/test_simple.html	View	1 chunk	+179 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/xhr/a.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webrequest/xhr/data.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

9 years, 4 months ago (2011-08-09 19:07:41 UTC) #2

On 2011/08/09 18:54:41, Matt Perry wrote:

LGTM thx!

Expand Messages | Collapse Messages